Skip to content

Conversation

bitwiseman
Copy link
Member

GHRepository#getIssues() has poor performance for large response sets and works against the best usage patterns. Deprecated in favor of #queryIssues().

Closes #2128

Description

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED" locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

GHRepository#getIssues() has poor performance for large response sets and works against the best usage patterns.   Deprecated in favor of #queryIssues().

Closes #2128
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.02%. Comparing base (47ef7a7) to head (2f0dd3b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2129   +/-   ##
=========================================
  Coverage     85.02%   85.02%           
  Complexity     2495     2495           
=========================================
  Files           237      237           
  Lines          7351     7351           
  Branches        388      388           
=========================================
  Hits           6250     6250           
  Misses          871      871           
  Partials        230      230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bitwiseman bitwiseman merged commit 970fd47 into main Aug 30, 2025
13 checks passed
@bitwiseman bitwiseman deleted the bitwiseman-patch-1 branch August 30, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHRepository#getIssues() takes 30s
1 participant