change_subscription called only when necessary (dpkp#1132)

Artimi · dpkp · commit 43939b29b58d · 2017-07-07T12:29:40.000-07:00
When we are using subscription by pattern change subscription is
called every metadata update even when nothing changes. This PR
ensures that change subscription is called only when set of topics
changes.
diff --git a/kafka/coordinator/consumer.py b/kafka/coordinator/consumer.py
@@ -140,8 +140,9 @@ def _handle_metadata_update(self, cluster):
                 if self._subscription.subscribed_pattern.match(topic):
                     topics.append(topic)
 
-            self._subscription.change_subscription(topics)
-            self._client.set_topics(self._subscription.group_subscription())
+            if set(topics) != self._subscription.subscription:
+                self._subscription.change_subscription(topics)
+                self._client.set_topics(self._subscription.group_subscription())
 
         # check if there are any changes to the metadata which should trigger
         # a rebalance
