refactor: adding changes to copy to clipboard #925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #925 +/- ##
=======================================
Coverage 85.14% 85.14%
=======================================
Files 806 806
Lines 16636 16638 +2
Branches 2093 2094 +1
=======================================
+ Hits 14164 14166 +2
Misses 2440 2440
Partials 32 32
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
| @@ -52,7 +52,7 @@ export class CopyToClipboardComponent implements OnInit, OnDestroy { | |||
| public size?: ButtonSize = ButtonSize.Small; | |||
|
|
|||
| @Input() | |||
| public icon?: IconType = IconType.CopyToClipboard; | |||
| public icon?: IconType = IconType.ContentCopy; | |||
There was a problem hiding this comment.
If this is different than copy to clipboard and meant to replace it, can we remove the old one
There was a problem hiding this comment.
I have to check with Michael on this, but this one looks better and is coming from material directly.
aaron-steinfeld
approved these changes
Jun 15, 2021
This comment has been minimized.
This comment has been minimized.
Unit Test Results 4 files 258 suites 12m 53s ⏱️ Results for commit e1d2f61. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.