Skip to content

Adding new style button #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 1, 2021
Merged

Adding new style button #963

merged 8 commits into from
Jul 1, 2021

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Jul 1, 2021 •
edited
Loading

Description

  • Add a new style called 'Plain Text' similar to 'Text' but without padding.

Testing

Visual testing.

  • 'Text' style with padding

image

  • 'Plain Text' style with no padding

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner July 1, 2021 15:50
@palbizu palbizu requested a review from anandtiwary July 1, 2021 15:53
@codecov
Copy link

codecov bot commented Jul 1, 2021 •
edited
Loading

Codecov Report

Merging #963 (6b7863f) into main (4e56e26) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #963   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files         812      812           
  Lines       16742    16742           
  Branches     2165     2165           
=======================================
  Hits        14238    14238           
  Misses       2473     2473           
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e56e26...6b7863f. Read the comment docs.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
anandtiwary
anandtiwary reviewed Jul 1, 2021
View reviewed changes
@palbizu palbizu requested a review from anandtiwary July 1, 2021 16:33
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
anandtiwary
anandtiwary approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@anandtiwary anandtiwary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we really need a no padding version for Text display mode. But it is fine for now. We can come back to it later if required.

@palbizu palbizu merged commit 98029d2 into main Jul 1, 2021
@palbizu palbizu deleted the AddingNewStyleButton branch July 1, 2021 20:33
@github-actions
Copy link

github-actions bot commented Jul 1, 2021

Unit Test Results

    4 files  ±0  259 suites  ±0   14m 54s ⏱️ -1s
937 tests ±0  937 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
943 runs  ±0  943 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 98029d2. ± Comparison against base commit 4e56e26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandtiwary anandtiwary anandtiwary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palbizu @anandtiwary