created CircleCI config for sonar analysis #1664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit is likely to fail the CircleCI job as the build doesn't has the environment ready yet. As soon as I get confirmation of the readiness of the environment I will push the second commit that is already waiting for the things to get confirmed that It is running all fine. |
|
@iluwatar I believe we can merge this now. |
|
Kudos, SonarCloud Quality Gate passed!
|
iluwatar
approved these changes
Mar 1, 2021
|
Nice work @ohbus, looking forward to seeing this feature in action! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help run sonar analysis on pull requests from forked repositories as this is our primary source of contributions.
The benefits has already been discussed here as it will resolve #1663
There are a few license format changes that has been amended to this Pull Request as well, which lies beyond the scope of this PR.