Skip to content

Update App.java #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2021
Merged

Update App.java #1898

merged 1 commit into from
Oct 31, 2021

Conversation

harshalkh
Copy link
Contributor

Sonar issue fix

Pull request description

  • replace all occurance of duplicate strings with defined constant

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@harshalkh
Copy link
Contributor Author

harshalkh commented Oct 29, 2021 •
edited
Loading

@iluwatar @ohbus please review...

@iluwatar iluwatar self-assigned this Oct 31, 2021
@iluwatar iluwatar added this to the 1.25.0 milestone Oct 31, 2021
@iluwatar iluwatar merged commit 22ddd57 into iluwatar:master Oct 31, 2021
@iluwatar
Copy link
Owner

Thank you for the Sonar fixes!
@all-contributors please add @harshalkh for code

@allcontributors allcontributors bot mentioned this pull request Oct 31, 2021
Merged
@allcontributors
Copy link
Contributor

@iluwatar

I've put up a pull request to add @harshalkh! 🎉

RobbiNespu pushed a commit to RobbiNespu/java-design-patterns that referenced this pull request Mar 1, 2022
@harshalkh @RobbiNespu
sonar fix: Update App.java (iluwatar#1898)
fafbc4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees

@iluwatar iluwatar

Labels
status: under review
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@harshalkh @iluwatar