Object Mother pattern #498 #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a simple king and queen classes which implement the behaviour of the royalty interface. Also wrote the object mother of royalty objects which is final so you can just call the static methods in it to create objects with a specific state to use them fast in tests. The tests are already created for testing the behaviour and the type of the objects which are created by the object mother. I also created the UML diagrams via object aid and updated the readme.
|
The |
iluwatar
reviewed
Oct 22, 2016
|
|
||
| @Test | ||
| public void queenIsBlockingFlirtCauseDrunkKing() { | ||
| King soberUnhappyKing = RoyaltyObjectMother.createDrunkKing(); |
iluwatar
reviewed
Oct 22, 2016
|
|
||
| @Test | ||
| public void queenIsBlockingFlirt() { | ||
| King soberUnhappyKing = RoyaltyObjectMother.createHappyKing(); |
iluwatar
reviewed
Oct 22, 2016
|
|
||
| @Test | ||
| public void successfullKingFlirt() { | ||
| King soberUnhappyKing = RoyaltyObjectMother.createHappyKing(); |
Deleted </modules> tag because i added it one time more than neccessary
|
@igeligel is this ready for another review? |
|
Yeah, i have messed up the pom.xml at some commit but fixed it then. I also renamed the code parts where you wanted a change. |
|
Looks good @igeligel. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the object mother pattern and all diagrams to the context.