-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Description
I was trying to figure out wherever Immutable.js declares its TypeScript support policy? In other words: which is the lowest supported version of TypeScript?
In the readme “TypeScript v2.1.0 or higher“ is mentioned:
Lines 128 to 129 in aa51198
Installing `immutable` via npm brings with it type definitions for Flow (v0.55.0 or higher) | |
and TypeScript (v2.1.0 or higher), so you shouldn't need to do anything at all! |
But in CI the lowest tested version is 4.5 (context: #1988 (comment)):
immutable-js/.github/workflows/ci.yml
Line 69 in aa51198
- run: npm run test:types -- --target 4.5,5.0,current |
Seems like the readme might be outdated.
A good question is, if it should say: “you will need TypeScript 4.5 or higher”, or better: “you will need TypeScript 5.0 or higher”?
I am suggesting TypeScript 5.0, because I would like to drop suport for TypeScript 4.x in the next release of TSTyche (tstyche/tstyche#372). The reason: TypeScript 5.0 will be two years soon and DefinitelyTyped already dropped support for 4.x, microsoft/DefinitelyTyped-tools#1110. (They dropped testing, to be exact.)
In the other hand, it would not be nice to make any changes that block Immutable.js to upgrade TSTyche.
That is why I was wondering to ask about your plans of TypeScript support policy?