Skip to content

Cursor.size not available from cursor.cursor()-created cursors #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wmertens opened this issue Mar 18, 2015 · 2 comments
Closed

Cursor.size not available from cursor.cursor()-created cursors #398

wmertens opened this issue Mar 18, 2015 · 2 comments

Comments

@wmertens
Copy link
Contributor

What happens is that when makeCursor is called from subCursor, it will always have 4 arguments and https://github.com/facebook/immutable-js/blob/257b92c6887ae787da9c94fbabe34056014ffc93/contrib/cursor/index.js#L223 doesn't get run and thus size is undefined.

So either the check has to be if (typeof value === 'undefined') or the subCursor has to to do call magic.
@jeroencranendonk-wf
Copy link
Contributor

See #318

@wmertens wmertens mentioned this issue Mar 23, 2015
Merged
@wmertens
Copy link
Contributor Author

I think you meant #381 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leebyron @wmertens @jeroencranendonk-wf