fixed #1313 by fixing two borked reducers #1315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Great catch, I like this fix |
errendir
added a commit
to errendir/immutable-js
that referenced
this pull request
Sep 30, 2017
…ings * facebook/master: (48 commits) 4.0.0-rc.3 Use latest immutable.js build on website Only build docs on tagged releases (immutable-js#1321) Relicense as MIT (immutable-js#1320) Fix rendering issue on tall screens Merge immutable-js#1285 Do not throw from hasIn (immutable-js#1319) Add more flow tests for Records Upgrade prettier and jest (immutable-js#1318) Merge immutable-js#1193 Minor flow record fixes Merges immutable-js#1195 fixed immutable-js#1290 by removing relative position from star count (immutable-js#1317) Fix deploy script Adds a script which automatically builds a #npm branch (immutable-js#1316) Use .github directory Merges immutable-js#1314 Flow config ignore all node_modules Update to latest version of flow (immutable-js#1312) fixed immutable-js#1313 by fixing two borked reducers (immutable-js#1315) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the right way to fix this because i'm unsure about the initial values in the reducers but it definitely fixes #1313 for me and looks fine locally.