-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Adds support for symbols as keys in Maps. #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5c6571f
Adds support for symbols as keys in Maps.
abacaphiliac 7b7b799
checks for existence of `Object.getOwnPropertySymbols` before using i…
abacaphiliac a731e4f
Merge remote-tracking branch 'facebook/master' into map-key-symbols
abacaphiliac 9151ed6
avoid key concatenation in ObjectSeq when Symbols are not available.
abacaphiliac cf479f7
update shallowCopy to handle Symbol keys in objects.
abacaphiliac c0629bc
consolidate ObjectSeq key initializer and remove unnecessary else con…
abacaphiliac 7dce2e4
Skip concat in Map instantiation and loop in shallowCopy when objects…
abacaphiliac cb41214
Merge remote-tracking branch 'facebook/master' into map-key-symbols
abacaphiliac 6f5a47f
removes Symbol-handling logic from Seq and shallowCopy due to perform…
abacaphiliac 7963603
Merge remote-tracking branch 'facebook/master' into map-key-symbols
abacaphiliac c6dad00
Renames Map.ownEntries to Map.fromOwnEntries, adds explicit test case…
abacaphiliac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -868,6 +868,7 @@ declare class Map<K, +V> extends KeyedCollection<K, V> mixins UpdatableInCollect | |
|
||
size: number; | ||
|
||
fromOwnEntries(obj: mixed): Map<K, V>; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This would be |
||
set<K_, V_>(key: K_, value: V_): Map<K | K_, V | V_>; | ||
delete(key: K): this; | ||
remove(key: K): this; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I don't think this recursion is something we want to encourage - that would result in a deep exploration of a data structure which could be very slow, that might be surprising to someone who thought this worked like the other constructors which are all shallow - if an inner value is intended to also be a map, then explicitly calling this in user code will both make that use case clear, avoid unnecessary recursion and make ts/flow more accurate.
If I understand correctly, this function should just become:
Given the simplicity of this function, how it is likely to be used less often than the standard constructor, how tree-shaking often does not yet remove static methods, and your pointing out that your use case may desire recursion to be more ergonomic, do you think it should live in the core library directly? I'm thinking that this could probably be either a single function in someone's own codebase or a micro library on npm (
immutable-map-from-own-entries
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i completely agree. i'm ok with closing this now, unless you think there is something else to discuss. thanks for going on this adventure with me : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks again. i'm closing this request now.