Skip to content

Adds test to demo key Symbol in Map.set() #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Adds test to demo key Symbol in Map.set() #1394

merged 1 commit into from
Oct 17, 2017

Conversation

abacaphiliac
Copy link
Contributor

Adds test to demonstrate usage of Symbol primitive data type as Map key via set method, which does not work upon Map instantiation.

Split from #1392

…ey via set method, which does not work upon Map instantiation.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@abacaphiliac
Copy link
Contributor Author

@leebyron please review.

I'm working on another request right now for the Map instantiation performance test(s).

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@leebyron leebyron merged commit 73dbeac into immutable-js:master Oct 17, 2017
@leebyron
Copy link
Collaborator

Great! thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants