Use prettier for tests #1403
Closed
Use prettier for tests #1403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working on projects that use prettier, I enable the format-on-save option in my editor of choice which run prettier whenever I save a file. This always updated the formatting of the tests files when working on Immutable.js, since those files were not formatted using prettier yet. Prettier added [typescript support][1] in the mean time, so I thought it was a good idea to keep the whole code base consistent and to allow everyone to use format-on-save without getting annoyed. Since there are not a lot of PRs open, I think it's a good time to merge this. [1]: https://github.com/prettier/prettier/releases/tag/1.4.0
|
We've been using https://github.com/vvakame/typescript-formatter for some time for what it's worth. |
|
Awesome, I've been meaning to do this, so thank you for taking the initiative |
leebyron
added a commit
that referenced
this pull request
Oct 18, 2017
Squashed commit of the following: commit de04ab9ad875e8225eb723efb4217c621d15e6bd Merge: 09dc022 6b74e23 Author: Lee Byron <lee@leebyron.com> Date: Wed Oct 18 13:15:16 2017 -0700 Merge branch 'philipp/pretty-tests' of https://github.com/philipp-spiess/immutable-js into philipp-spiess-philipp/pretty-tests commit 6b74e23 Author: Philipp Spiess <hello@philippspiess.com> Date: Wed Oct 18 10:56:17 2017 +0200 Use prettier for tests When working on projects that use prettier, I enable the format-on-save option in my editor of choice which run prettier whenever I save a file. This always updated the formatting of the tests files when working on Immutable.js, since those files were not formatted using prettier yet. Prettier added [typescript support][1] in the mean time, so I thought it was a good idea to keep the whole code base consistent and to allow everyone to use format-on-save without getting annoyed. Since there are not a lot of PRs open, I think it's a good time to merge this. [1]: https://github.com/prettier/prettier/releases/tag/1.4.0
errendir
added a commit
to errendir/immutable-js
that referenced
this pull request
Dec 8, 2017
* facebook/master: (305 commits) Reduce repetition in COC link `CONTRIBUTING.md` Add CODE_OF_CONDUCT.md fix typo Add link to Code of Conduct in CONTRIBUTING Improved Flow support for Record subclasses (immutable-js#1414) Improve asImmutable() docs (immutable-js#1415) Only include version in require statement in Runkit instances. (immutable-js#1411) Add example for OrderedSet subtract. (immutable-js#1410) Fix code samples in Immutable.d.ts docs (immutable-js#1408) Adds perf tests for `Map.merge`. (immutable-js#1407) Move gulpfile into resources/ Prettier: perf tests Prettier: include resources Prettify: Use es5 trailing commas Merge immutable-js#1403 Document regression test steps. (immutable-js#1405) Demonstrates correct handling of Symbol keys in Map.mergeDeep when the Maps are nested, and initialized with Symbol KV tuples instead of plain JS object literals. (immutable-js#1404) Fix Map#concat (immutable-js#1402) test(ts-definitions): test Immutable.d.ts validity using tsc (immutable-js#1401) 4.0.0-rc.9 ...
errendir
added a commit
to errendir/immutable-js
that referenced
this pull request
Dec 8, 2017
* facebook/master: (305 commits) Reduce repetition in COC link `CONTRIBUTING.md` Add CODE_OF_CONDUCT.md fix typo Add link to Code of Conduct in CONTRIBUTING Improved Flow support for Record subclasses (immutable-js#1414) Improve asImmutable() docs (immutable-js#1415) Only include version in require statement in Runkit instances. (immutable-js#1411) Add example for OrderedSet subtract. (immutable-js#1410) Fix code samples in Immutable.d.ts docs (immutable-js#1408) Adds perf tests for `Map.merge`. (immutable-js#1407) Move gulpfile into resources/ Prettier: perf tests Prettier: include resources Prettify: Use es5 trailing commas Merge immutable-js#1403 Document regression test steps. (immutable-js#1405) Demonstrates correct handling of Symbol keys in Map.mergeDeep when the Maps are nested, and initialized with Symbol KV tuples instead of plain JS object literals. (immutable-js#1404) Fix Map#concat (immutable-js#1402) test(ts-definitions): test Immutable.d.ts validity using tsc (immutable-js#1401) 4.0.0-rc.9 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on projects that use prettier, I enable the format-on-save
option in my editor of choice which run prettier whenever I save a file.
This always updated the formatting of the tests files when working on
Immutable.js, since those files were not formatted using prettier yet.
Prettier added typescript support in the mean time, so I thought
it was a good idea to keep the whole code base consistent and to allow
everyone to use format-on-save without getting annoyed.
Since there are not a lot of PRs open, I think it's a good time to merge
this.