Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Is this ever going to be incorporated? Or is the position of immutable that they will not support this use case (in particular, using moment() )

I don't know :/

For me it wasn't moment, it was a Decimal, but it breaks for anything that implements valueOf. So it definitely needs fixing.

@asazernik do you have any insight about what I can do to get this merged?

The problem is easy to reproduce with Date. It looks like any value greater than Date(8) will crash Immutable. This is true even if the Date instance is part of a Map or Record, which is in turn a member of a Set.

This makes Immutable completely break for our application, and we've had to refactor away all uses of Immutable Set. Hopefully this PR can get merged and a new rc released soon.

const { Set } = require("immutable")

const bad = []
let set = Set()
let i = 0

while (true) {
  i++
  try {
    set = set.add(new Date(i))
    console.log(i, "is ok")
  } catch (err) {
    console.log(i, err.message)
    bad.push(i)
  }
  if (bad.length > 100) {
    console.log(bad)
    break
  }
}

@leebyron You were the last one to complete a merge into this repo, so is there any chance to get this fix merged in? Or is there anyone else we can tag to get this resolved?

Lack of activity and commit history suggest this repo died on Valentine’s Day 2019 :/ RIP, even true, immutable-love isn’t forever 💔

@aaronwhite it kind of goes into hibernation, and then gets a burst of pulls every month or three.

Can someone please merge this? The regression is 9 months old, and this fix was requested 8 months ago.

Is @leebyron still the maintainer, or is there someone else who can commit this?

@EricTheRed-VT It honestly looks like this project is proper dead. It's been 5 months since a commit, and I haven't seen a single person with merge authority so much as comment. My recommendation is to move off of this library entirely sooner rather than later.

@TikiTDO We're pretty happy with it in general, aside from the rare bug like this. Dropping Immutable would be too costly for my team, not to mention that there isn't a good replacement library (that I'm aware of). If this really never gets fixed, we might have to fork it and maintain a private version. 😞

It's just hard to believe that a widely popular library like this would be completely abandoned.

Thanks your for your contribution ! The immutable-js oss fork will soon be merged and this fix has been included in #1833 (possibly by you !). Once this PR is merged, this issue will be resolved in the main branch. We will then do our best to to release the 4.0.0 version.

Commit reference : 45196e3