Skip to content

Convert website to Next.js #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2021
Merged

Convert website to Next.js #1830

merged 1 commit into from
Jun 25, 2021

Conversation

leebyron
Copy link
Collaborator

@leebyron leebyron commented Jun 20, 2021 •
edited
Loading

Preview: https://out-i3rlqnnx6-leebyron.vercel.app/

  • Converts website from manual gulpfile & router to Next.js, removing outdated packages
  • Updated to latest version of React, updates all website components
  • Convert all website resources to Typescript
  • Simplification of type docs generation
  • Fixed many latent bugs
  • Exports docs for multiple versions

@leebyron leebyron force-pushed the next-website branch 5 times, most recently from e5091f0 to b73b1ce Compare June 22, 2021 00:10
@bdurrer
Copy link
Contributor

bdurrer commented Jun 22, 2021 •
edited
Loading

Hmm we redone the docs on the OSS-fork too:

  • use the latest React
  • can show multiple versions
  • Fix a few bugs
  • added/fixed router for permanent linking to specific parts

I am unsure how to proceed here, it's certainly a 100% conflict. Maybe we should discuss on slack on how to proceed in general.
It should not to generate pressure or workload for you, all we need is a common understanding on how to continue

https://join.slack.com/t/immutable-js/shared_invite/zt-qx06n7ok-lRhNE8nvLUW_vH3t7_G~rw

@leebyron
Copy link
Collaborator Author

Hey @bdurrer, I'm so sorry about the conflict. I've been trying to get this surface back to a maintainable state and started with updating packages and CI and followed with getting the website into a maintainable position. I took a look at the fork for changes to the website and didn't see any, but clearly I just missed that work!

I think this change is ready to land and includes the improves you mentioned here. I'll join that Slack to discuss further.

@leebyron leebyron marked this pull request as ready for review June 24, 2021 22:26
@leebyron leebyron force-pushed the next-website branch 9 times, most recently from 93df87b to 8dcaa0f Compare June 25, 2021 00:13
@leebyron leebyron merged commit caeae12 into main Jun 25, 2021
@leebyron leebyron deleted the next-website branch June 25, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leebyron @bdurrer