Skip to content

upgrade to jest 27 and jasmine-check to 1.0.0-rc #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2021
Merged

upgrade to jest 27 and jasmine-check to 1.0.0-rc #1874

merged 3 commits into from
Sep 16, 2021

Conversation

jdeniau
Copy link
Member

@jdeniau jdeniau commented Sep 16, 2021

I tried to replace #1849 by a better version now that jest should handle async transform since 27.0.

I did not manage easily to drop this make-synchronous or synckit call, I got a lot of different issues and I spent a lot of time already on it, but jest 27 does work fine 👍

@jdeniau jdeniau changed the title upgrade to jest 27 upgrade to jest 27 and jasmine-check to 1.0.0-rc Sep 16, 2021
@jdeniau jdeniau marked this pull request as ready for review September 16, 2021 11:04
@jdeniau jdeniau requested review from leebyron and a team and removed request for leebyron September 16, 2021 11:13
package.json Outdated
"devDependencies": {
"@types/jest": "26.0.24",
"@types/jest": "^27.0.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you set these to exact versions?

@leebyron
Copy link
Collaborator

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants