Fix issue with OrderedMap, OrderedSet and hashCode #2005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when generating the
hashCode
of an element, we do use the size returned by__iterate
. But in case ofOrdered
element, the internal representation of the underlying list might contain undefined elements :Example:
m.size is 1, the
__iterate
function will iterate only one time on theb
key, but the internal_list
element, will have two elements:[undefined, ['b', 'b']]
:See https://runkit.com/jdeniau/immutable-hashcode-using-internal-list-size
I think that we should not use the value returned by
__iterate
, and use the object size directly.Fixes #2002