Upgrade TSTyche #2034
Merged
Upgrade TSTyche #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you ! No problem for node 18, immutable is not use node api so it should work with old version of node. |
|
Thanks for quick review! |
jdeniau
added a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, it should feel amazing to release
immutable@5.0.0. Congrats!TSTyche 3.0 is coming out later this week. Seems like current release candidate will be published as it is. Release notes can be found here.
As I was mentioning before, the
.toMatch()matcher is deprecated. Thepick()type utility can be used instead.By the way, lowest supported Node.js version now is 18.19. That shouldn’t be a problem, or?