create single dist esm file to clear circular dependencies #2035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdeniau
approved these changes
Nov 7, 2024
| banner: copyright, | ||
| name: 'Immutable', | ||
| // generates one esm file with no circular imports | ||
| file: path.join(DIST_DIR, 'es', 'Immutable.js'), |
There was a problem hiding this comment.
As a matter of fact, it was like that before trying to resolve tree-shaking in 8dffce4#diff-a098417b5f500a442eab89048eb0705bf6acad8b8f76514b70d27ba2e10f55a5
But we can not resolve tree-shaking because everything is connected, so let's rollback to a single file 👍
|
Merged in 7452d39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2019
related: #2022