Skip to content

Upgrade typescript and typescript-eslint #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Upgrade typescript and typescript-eslint #2046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64449bd
upgrade typescript version
jdeniau Feb 12, 2025
ff309f6
upgrade ts-eslint to 8
jdeniau Feb 12, 2025
3e632ea
Do test output diff only if modified TS files are in `src` dir
jdeniau Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/pages/out/**
/pages/generated/**
/dist/**
node_modules
/type-definitions/flow-tests
2 changes: 1 addition & 1 deletion .github/workflows/output_diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
- init-migrate-to-ts
# run only if there is ts files in the PR
paths:
- '**/*.ts'
- 'src/**/*.ts'

jobs:
diff:
Expand Down
4 changes: 2 additions & 2 deletions __tests__/MultiRequire.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// eslint-disable-next-line @typescript-eslint/no-var-requires
// eslint-disable-next-line @typescript-eslint/no-require-imports
const Immutable1 = require('../src/Immutable');

jest.resetModules();

// eslint-disable-next-line @typescript-eslint/no-var-requires
// eslint-disable-next-line @typescript-eslint/no-require-imports
const Immutable2 = require('../src/Immutable');

describe('MultiRequire', () => {
Expand Down
1 change: 1 addition & 0 deletions __tests__/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"strictFunctionTypes": true,
"target": "esnext",
"moduleResolution": "node",
"skipLibCheck": true,
"paths": {
"immutable": ["../type-definitions/immutable.d.ts"],
"jasmine-check": ["../resources/jasmine-check.d.ts"]
Expand Down
Loading