Replace buble by babel #2050
Merged
Replace buble by babel #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
994292a to
95dc7d6
Compare
ad33ed6 to
075bb4b
Compare
075bb4b to
a3d2a26
Compare
a3d2a26 to
817fe23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buble was nice, but does compile the code to ES2015.
It's 2025 now, and a lot of browser does support "modern" features like classes.
BC Break notice
This is breaking as we do now transpile for modern browser only ("last 2 version" + "not dead").
This drop support for older browsers that have been supported until immutable v5. For example IE <= 12 or safari <= 8 are not supported anymore.
If you still need to support those old browser, then you MAY want to transpile the node_modules/immutable/dist/index.js file yourself. (and you are probably already doing that for a lot of other packages that dropped support of ES5 with tools like https://github.com/obahareth/are-you-es5 of by enable babel on all node_modules)
bundle size gain
For the record migrating to a modern codebase had a nice impact of the size of the built file (non-gzipped values) :