Skip to content

Fix Uncaught TypeError: keyPath.slice is not a function for ArrayLike method #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Fix Uncaught TypeError: keyPath.slice is not a function for ArrayLike method #2065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 51 additions & 1 deletion __tests__/updateIn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,54 @@ describe('updateIn', () => {
);
});

it('handle ArrayLike objects that are nor Array not immutable Collection', () => {
class CustomArrayLike<T> implements ArrayLike<T> {
readonly length: number;
[n: number]: T;

constructor(...values: Array<T>) {
this.length = values.length;

for (let i = 0; i < values.length; i++) {
this[i] = values[i];
}
}

// Define other methods if needed, but do not include the `slice` method
// For example, you can define a method to set values
set(index: number, value: T): void {
if (index < 0 || index >= this.length) {
throw new RangeError('Index out of bounds');
}

this[index] = value;
}

// Define a method to get values
get(index: number): T {
if (index < 0 || index >= this.length) {
throw new RangeError('Index out of bounds');
}

return this[index];
}
}

// create an ArrayLike
const customArray = new CustomArrayLike<number>(10, 20);

// code that works perfectly
expect(
// @ts-expect-error -- `updateIn` keypath type should be `OrderedCollection<K> | ArrayLike<K>;
updateIn({ 10: { 20: 'a' } }, customArray, (v) => `${v.toUpperCase()}`)
).toEqual({ 10: { 20: 'A' } });

expect(() =>
// @ts-expect-error -- `updateIn` keypath type should be `OrderedCollection<K> | ArrayLike<K>;
updateIn({ 10: 'a' }, customArray, (v) => `${v.toUpperCase()}`)
).toThrow('Cannot update within non-data-structure value in path [10]: a');
});

it('identity with notSetValue is still identity', () => {
const m = Map({ a: { b: { c: 10 } } });
expect(m.updateIn(['x'], 100, (id) => id)).toEqual(m);
Expand Down Expand Up @@ -159,7 +207,9 @@ describe('updateIn', () => {
const m = fromJS({ a: { b: { c: 10 } } });
expect(() => {
m.updateIn(['a', 'b', 'c', 'd'], () => 20).toJS();
}).toThrow();
}).toThrow(
'Cannot update within non-data-structure value in path ["a","b","c"]: 10'
);
});

it('update with notSetValue when non-existing key', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/functional/updateIn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function updateInDeeply(
if (!wasNotSet && !isDataStructure(existing)) {
throw new TypeError(
'Cannot update within non-data-structure value in path [' +
keyPath.slice(0, i).map(quoteString) +
Array.from(keyPath).slice(0, i).map(quoteString) +
']: ' +
existing
);
Expand Down