Drop TS 4 support and add const P extends for getIn method types
#2072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
reviewed
Mar 19, 2025
| @@ -66,7 +66,7 @@ jobs: | |||
| - run: npm ci | |||
| - run: npm run build | |||
| - run: npm run test:unit | |||
| - run: npm run test:types -- --target 4.5,5.0,current | |||
| - run: npm run test:types -- --target 5.0,current | |||
There was a problem hiding this comment.
Nice! To draw your attention, tstyche@3.1.1 and above makes it possible to test agains a range of versions:
Suggested change
| - run: npm run test:types -- --target 5.0,current | |
| - run: npm run test:types -- --target '>=5.0' |
There was a problem hiding this comment.
Nice, but doing that the tests ran 5 times slower.
I do not know if it's worth it for now (but I do keep that in mind)
3505c94 to
9a567eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use const type parameters for getIn path retrieval.
This feature has been introduced in TS 5.0, which is more than two years old now. This PR drops support for TS < 5.0.