Define "exports" in package.json #2080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9723c23 to
1711791
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR is focused on updating the build configuration to better align with the defined "exports" in package.json, partially addressing issue #2064.
- Updated the output file extension in the Rollup configuration from .es.js to .mjs.
- Modified the Jest resolver to reference pkg.main instead of pkg.module in the CI environment.
- Adjusted the build output check to validate files based on the new exports fields in package.json.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| resources/rollup-config.mjs | Changed output file extension to better reflect ESM modules. |
| resources/jestResolver.js | Updated the CI resolver to use pkg.main rather than pkg.module. |
| resources/check-build-output.mjs | Revised expected file list to reference the exports objects. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (3)
resources/rollup-config.mjs:49
- Ensure that renaming the output file to .mjs is consistent with all related configuration and references elsewhere in the project.
file: path.join(DIST_DIR, 'immutable.mjs'),
resources/jestResolver.js:8
- Verify that using pkg.main in the CI environment correctly points to the intended build output, as changing from pkg.module may affect module resolution behavior.
return path.resolve(options.rootDir, pkg.main);
resources/check-build-output.mjs:11
- Confirm that the package.json exports field is defined with the expected keys ('require', 'import', and 'types') so that the build output check accurately verifies the right files.
removeDistPrefix(packageJsonContent.exports['.'].require),
1711791 to
a1115ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #2064