makeCursor may return incorrect cursor type #297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain code paths call makeCursor with four arguments, with 'value' undefined. Since arguments.length is still four in this case, the value is not retrieved from rootData, and an incorrect cursor type can be generated.
| var data = Immutable.fromJS({ a: [1, 2, 3] }); | ||
| var cursor = Cursor.from(data); | ||
| var deepCursor = <any>cursor.cursor('a'); | ||
| expect(deepCursor.findIndex).toBeDefined(); |
There was a problem hiding this comment.
Probably not the best way to test this. I'm open to suggestions.
|
Any updates on this? |
|
Thanks for adding this. I'm a bit behind on reviewing PRs, but I promise to dig into it soon. |
|
+1 |
|
I created an alternate PR for this #381 which continues to use |
|
Closing in favor of @jeffbski's fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain code paths call makeCursor with four arguments, with 'value' undefined. Since arguments.length is still four in this case, the value is not retrieved from rootData, and an incorrect cursor type may be generated.
Fixes #318
(As a side effect, this change may also make makeCursor eligible for VM optimizations.)