added List methods push, pop, unshift, shift to List IndexedCursor #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is big for me, really hinders ability to use of cursors until this is fixed! 👍 👍 |
|
@natew If there are other methods that are missing, let me know, I'm happy to implement them too. |
|
wow, this is so great, exactly the things I need. Can't wait for it |
leebyron
added a commit
that referenced
this pull request
Mar 27, 2015
added List methods push, pop, unshift, shift to List IndexedCursor
|
Nice work, thanks for your patience! |
|
I'm not sure how to push regular JS items onto an immutable cursor List, this doesn't work: immutableStore.push.apply(null, jsarray);I've tried a few variations I keep getting: Possibly unhandled TypeError: Cannot read property 'updateIn' of undefined
at updateCursor (webpack:///./~/immutable/contrib/cursor/index.js?:279:37) |
|
@natew can you give a full testcase? Somewhere as a gist or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add some methods to the Cursor API because they are missing. This solves #346.
I'm not sure if this is the right way to do it, because all other methods extend both KeyedCursorPrototype and IndexedCursorPrototype and this only extends IndexedCursorPrototype. So all feedback is more then welcome!