toString(): Print keys in JSON #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, it's obvious when numeric keys are being mixed with string keys, like when importing from JSON and inserting by key.
|
Thanks, this makes tons of sense. I wholey agree that being explicit about key types when stringed helps explain the difference from objects, and naked strings look far too much like property names, which they are not. |
leebyron
added a commit
that referenced
this pull request
Mar 16, 2015
toString(): Print keys in JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, it's obvious when numeric keys are being mixed with string
keys, like when importing from JSON and inserting by key.