Skip to content
This repository was archived by the owner on Jul 23, 2021. It is now read-only.

List.insert makes the inserted object into an array in IE 11 #135

Closed
Methuselah96 opened this issue Oct 17, 2020 · 3 comments
Closed

List.insert makes the inserted object into an array in IE 11 #135

Methuselah96 opened this issue Oct 17, 2020 · 3 comments
Labels
bug Something isn't working from-original-repo
Milestone

Comments

@Methuselah96
Copy link

From @Bowen0 on Tue, 21 May 2019 10:56:08 GMT

What happened

List.insert makes the inserted object into an array in IE 11

IE version : 11.648.17134.0

I use IE 11 to open https://immutable-js.github.io/immutable-js/docs/#/List to test in the console.

How to reproduce

  1. Defined an object list
  2. Insert an object at the beginning of the list
  3. The first object becomes an array

e.g.

var a= Immutable.fromJS({ a: 0 })
var b = Immutable.fromJS({ b: 0 })
var c = Immutable.fromJS({ c: 0 });
var list = Immutable.fromJS([b, c])

var newlist = list.insert(0, a); 
// expect [Object, Object, Object]
// actual:  [Array, Object, Object]

pic
image

Copied from original issue: immutable-js#1711

@Methuselah96
Copy link
Author

Methuselah96 commented Nov 20, 2020

Likely fixed by #194, but should be tested to make sure.

@Methuselah96 Methuselah96 added this to the 4.0 milestone Nov 20, 2020
@jdeniau
Copy link

jdeniau commented Nov 28, 2020

Fixed in master by #194

On immutable website (4.0.0-rc.12)
image

With the build on master
image

@Methuselah96
Copy link
Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working from-original-repo
Projects
None yet
Development

No branches or pull requests

2 participants