Skip to content
This repository was archived by the owner on Jul 23, 2021. It is now read-only.

[Bug] isPlainObj fn not compatible for IE11 #159

Closed
Methuselah96 opened this issue Oct 17, 2020 · 2 comments · Fixed by #194
Closed

[Bug] isPlainObj fn not compatible for IE11 #159

Methuselah96 opened this issue Oct 17, 2020 · 2 comments · Fixed by #194
Labels
bug Something isn't working from-original-repo
Milestone
4.0

Comments

@Methuselah96
Copy link

From @binarykitchen on Thu, 31 Oct 2019 02:53:06 GMT

This implementation is breaking on IE11

  function isPlainObj(value) {
    return (
      value &&
      (typeof value.constructor !== 'function' ||
        value.constructor.name === 'Object')
    );
  }

Always returns false.

Refer to https://stackoverflow.com/questions/25140723/constructor-name-is-undefined-in-internet-explorer

Copied from original issue: immutable-js#1745
@Methuselah96 Methuselah96 added this to the 4.0 milestone Oct 31, 2020
@Methuselah96 Methuselah96 added bug Something isn't working and removed needs investigation labels Oct 31, 2020
@Methuselah96
Copy link
Author

Methuselah96 commented Oct 31, 2020 •
edited
Loading

Related: immutable-js#1648

@bdurrer
Copy link

bdurrer commented Nov 19, 2020

The current function also fails to correctly detect objects which have property 'constructor' that has a property 'name':

// will return false
isPlainObj({ constructor: { name: 'bamboozled' }});

bdurrer added a commit to bdurrer/immutable-js that referenced this issue Nov 19, 2020
@bdurrer
FIX: support isPlainObj in IE11 and constructor.name props (immutable…
7b819e3 
…-js-oss#159)
bdurrer added a commit to bdurrer/immutable-js that referenced this issue Nov 19, 2020
@bdurrer
FIX: support isPlainObj in IE11 and constructor.name props (immutable…
ea625c9 
…-js-oss#159)
@conartist6 conartist6 linked a pull request Nov 20, 2020 that will close this issue
Fix #159: support isPlainObj in IE11 and constructor.name props #194
Merged
bdurrer added a commit to bdurrer/immutable-js that referenced this issue Nov 20, 2020
@bdurrer
Fix immutable-js-oss#159: Support isPlainObj in IE11 and constructor.…
920e968 
…name props
bdurrer added a commit to bdurrer/immutable-js that referenced this issue Nov 20, 2020
@bdurrer
Fix immutable-js-oss#159: Support isPlainObj in IE11 and constructor.…
9776463 
…name props
bdurrer added a commit to bdurrer/immutable-js that referenced this issue Nov 20, 2020
@bdurrer
Fix immutable-js-oss#159: Support isPlainObj in IE11 and constructor.…
8dc3dd8 
…name props
bdurrer added a commit to bdurrer/immutable-js that referenced this issue Nov 20, 2020
@bdurrer
Fix immutable-js-oss#159: Support isPlainObj in IE11 and constructor.…
8171bae 
…name props
bdurrer added a commit to bdurrer/immutable-js that referenced this issue Nov 20, 2020
@bdurrer
Fix immutable-js-oss#159: Support isPlainObj in IE11 and other esoter…
8e5496b 
…ic parameters
bdurrer added a commit to bdurrer/immutable-js that referenced this issue Nov 20, 2020
@bdurrer
Fix immutable-js-oss#159: Support isPlainObj in IE11 and other esoter…
cfeebcd 
…ic parameters
bdurrer added a commit to bdurrer/immutable-js that referenced this issue Nov 20, 2020
@bdurrer
Fix immutable-js-oss#159: Support isPlainObj in IE11 and other esoter…
d047d7b 
…ic parameters
Methuselah96 pushed a commit that referenced this issue Nov 20, 2020
@bdurrer
Fix #159: Support isPlainObj in IE11 and other esoteric parameters (#194
f3a6d5c 
)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working from-original-repo
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Fix #159: support isPlainObj in IE11 and constructor.name props bdurrer/immutable-js
2 participants
@bdurrer @Methuselah96