Ensure hash works with moment #199
Conversation
| @@ -101,6 +101,7 @@ | |||
| "marked": "1.2.3", | |||
| "microtime": "^3.0.0", | |||
| "mkdirp": "0.5.1", | |||
| "moment": "^2.29.1", | |||
There was a problem hiding this comment.
@conartist6 Any thoughts about taking on devDependencies in order to test them? I think I would prefer not to, and since this bug already has a test from your PR, we don't need to write a new one.
There was a problem hiding this comment.
No I don't think we should if we can avoid it. Instead we should find the root cause of the incompatibility with such a dependency and simulate it ourselves. That way we make it clear to authors of any library what they can safely do. We don't want to discourage competition.
There was a problem hiding this comment.
Yeah, this was an issue that was fixed by #17, so I'm just going to close and the corresponding issue since it's been fixed.
|
Thanks for for checking to make sure this was fixed @jdeniau. |
Fixes #101