This repository was archived by the owner on Jul 23, 2021. It is now read-only.
Fix ordered set with map #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdeniau
commented
Dec 1, 2020
| // keep track if the set is altered by the map function | ||
| let didChanges = false; | ||
|
|
||
| const newMap = updateSet( |
There was a problem hiding this comment.
I reused updateSet here as it was the base implementation (see here for the original implementation)
Methuselah96
approved these changes
Dec 8, 2020
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115
This issue has been introduced by immutable-js#1606 : to keep the reference equality, it did remove and add all values that changes.
I tried several implementations to fix this, and finally used the other approach that @jessezhang91 dropped for a really small performance reason : replace the
.mapby a.mapEntriesand keep track if at least one value did change.