Skip to content
This repository was archived by the owner on Jul 23, 2021. It is now read-only.

Test that #41 is fixed #207

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Test that #41 is fixed #207

merged 2 commits into from
Dec 8, 2020

Conversation

jdeniau
Copy link

@jdeniau jdeniau commented Dec 7, 2020

Fixes #41.

Probably fixed by #194

Methuselah96
Methuselah96 suggested changes Dec 8, 2020
View reviewed changes
Copy link

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSLint error:

__tests__/fromJS.ts:10:12

ERROR: 10:12  no-var-requires  require statement not part of an import statement

@jdeniau
Copy link
Author

jdeniau commented Dec 8, 2020

@Methuselah96 lint fixed. I simply ignored the rule as vm is a node core module and thus needs to be "required" if I understand correctly

Methuselah96
Methuselah96 approved these changes Dec 8, 2020
View reviewed changes
Copy link

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's fine.

@Methuselah96 Methuselah96 merged commit 954d75b into immutable-js-oss:master Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Methuselah96 Methuselah96 Methuselah96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fromJS() only works on Objects in the same Realm
2 participants
@jdeniau @Methuselah96