Skip to content

Release v1.4.1 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2024
Merged

Release v1.4.1 #137

merged 1 commit into from
Apr 19, 2024

Conversation

ohakutsu
Copy link
Member

What

v1.4.1をリリースする。変更点は以下。

How

Why

Refs

@ohakutsu ohakutsu self-assigned this Apr 17, 2024
@ohakutsu ohakutsu requested review from a team and kimkim0814 and removed request for a team April 17, 2024 09:43
@kimkim0814
Copy link
Member

@ohakutsu
開発環境で以下のように、出ることは許容しますか?

バージョンアップする際に、ローカル環境で毎回出るので
下記のロジックをバージョン比較してcurrentVersionがlatestVersionより新しい場合は
nullを返すようにしても良いのかなとも思いました!

qiita-cli/src/lib/package-update-notice.ts

Lines 11 to 13 in a59da45

if (currentVersion === latestVersion) {
return null;
} 

qiita-cli % yarn run qiita help
yarn run v1.22.19
$ node dist/main.js help

   ╭─────────────────────────────────────────────────────────────────╮
   │                                                                 │
   │   新しいバージョンがあります!  1.4.1-> 1.4.0                   │
   │   npm install @qiita/qiita-cli@latest でアップデートできます!   │
   │                                                                 │
   ╰─────────────────────────────────────────────────────────────────╯

USAGE:
qiita <COMMAND> [<OPTIONS>]

COMMAND:
  init                    記事をGitHubで管理するための初期設定
  login                   Qiita APIの認証認可
  new [<basename>] ...    新しい記事を追加
  preview                 コンテンツをブラウザでプレビュー
  publish <basename> ...  記事を投稿、更新
  publish --all           全ての記事を投稿、更新
  pull                    記事ファイルをQiitaと同期
  version                 Qiita CLIのバージョンを表示
  help                    ヘルプを表示

kimkim0814
kimkim0814 reviewed Apr 18, 2024
View reviewed changes
actions/publish/action.yml
@@ -18,7 +18,7 @@ runs:
with:
node-version: "18.16.0"
- name: Install qiita-cli
run: npm install -g @qiita/qiita-cli@v1.4.0
run: npm install -g @qiita/qiita-cli@v1.4.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝
CIを変更しており、下記が問題なくpassしている
https://github.com/increments/qiita-cli/actions/runs/8719270989/job/23918287821?pr=137

@ohakutsu
Copy link
Member Author

@kimkim0814

下記のロジックをバージョン比較してcurrentVersionがlatestVersionより新しい場合は
nullを返すようにしても良いのかなとも思いました!

良いと思います👍
ただ、このPull Requestではバージョンを上げるだけにします！

@ohakutsu ohakutsu requested a review from kimkim0814 April 19, 2024 03:44
kimkim0814
kimkim0814 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@kimkim0814 kimkim0814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ohakutsu ohakutsu merged commit d0a272a into main Apr 19, 2024
6 checks passed
@ohakutsu ohakutsu deleted the release-v1.4.1 branch April 19, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimkim0814 kimkim0814 kimkim0814 approved these changes

Assignees

@ohakutsu ohakutsu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohakutsu @kimkim0814