Skip to content

Bump ws and @types/ws #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2023

Bumps ws and @types/ws. These dependencies needed to be updated together.
Updates ws from 8.14.1 to 8.15.1

Release notes

Sourced from ws's releases.

8.15.1

Notable changes

  • The allowMultipleEventsPerMicrotask option has been renamed to allowSynchronousEvents (4ed7fe58).

This is a breaking change in a patch release that could have been avoided with an alias, but the renamed option was added only 3 days ago, so hopefully it hasn't already been widely used.

8.15.0

Features

  • Added the allowMultipleEventsPerMicrotask option (93e3552e).

8.14.2

Bug fixes

  • Fixed an issue that allowed errors thrown by failed assertions to be swallowed when running tests (7f4e1a75).
Commits
  • a57e963 [dist] 8.15.1
  • 4ed7fe5 [major] Rename the allowMultipleEventsPerMicrotask option
  • fccc580 [fix] Emit the event when the microtask is executed
  • 297fff8 [dist] 8.15.0
  • 93e3552 [feature] Introduce the allowMultipleEventsPerMicrotask option
  • 603a039 [doc] Add JSDoc for the finishRequest option
  • c320738 [test] Fix nits
  • 5a3036e [test] Merge some tests
  • dd1994d [ci] Test on node 21
  • 208220d [lint] Fix prettier error
  • Additional commits viewable in compare view

Updates @types/ws from 8.5.5 to 8.5.10

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 18, 2023
@acronhub
Copy link
Contributor

8.15.1

Notable changes
The allowMultipleEventsPerMicrotask option has been renamed to
allowSynchronousEvents (websockets/ws@4ed7fe5).

オプションの名前が変更されったぽい
利用してなさそう

@acronhub acronhub self-requested a review December 21, 2023 08:36
@acronhub
Copy link
Contributor

📝 パッケージを入れ替えての動作確認

# パッケージ更新&確認
% yarn install

yarn install v1.22.19
warning ../../../../package.json: No license field
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
[5/5] 🔨  Building fresh packages...
$ husky install
husky - Git hooks installed
✨  Done in 3.81s.

yarn list
├─ @types/ws@8.5.10
# CLI実行確認
% yarn qiita

yarn run v1.22.19
warning ../../../../package.json: No license field
$ node dist/main.js
(node:95245) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
(Use `node --trace-warnings ...` to show where the warning was created)
Preview: http://[::1]:8888

実際に記事をCLIを使って更新してみた 🆗
Qiitaの記事エディタで更新してCLI Previewで確認してみた 🆗

acronhub
acronhub previously approved these changes Dec 21, 2023
Copy link
Contributor

@acronhub acronhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-and-types/ws-8.15.1 branch 2 times, most recently from 9b720e6 to c3833f9 Compare December 25, 2023 02:58
@acronhub
Copy link
Contributor

@dependabot rebase

Bumps [ws](https://github.com/websockets/ws) and [@types/ws](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ws). These dependencies needed to be updated together.

Updates `ws` from 8.14.1 to 8.15.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.14.1...8.15.1)

Updates `@types/ws` from 8.5.5 to 8.5.10
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ws)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: "@types/ws"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-and-types/ws-8.15.1 branch from c3833f9 to d4eaaf1 Compare December 25, 2023 03:01
Copy link
Contributor

@acronhub acronhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acronhub acronhub merged commit 2117fa8 into main Dec 25, 2023
@acronhub acronhub deleted the dependabot/npm_and_yarn/ws-and-types/ws-8.15.1 branch December 25, 2023 04:26
@acronhub acronhub mentioned this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant