Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods don't work on Sets #10

Open
ydinari opened this issue Aug 26, 2021 · 6 comments · May be fixed by #14
Open

Methods don't work on Sets #10

ydinari opened this issue Aug 26, 2021 · 6 comments · May be fixed by #14

Comments

@ydinari
Copy link

ydinari commented Aug 26, 2021

I want to work with sets, but the methods seem to expect unknown[].
@esromneb
Copy link

I'm also having this issue. I'm having to put // @ts-ignore before every line

@indrajaala
Copy link
Owner

indrajaala commented Dec 30, 2021 •
edited
Loading

i have tested all the methods, they are working fine , data must be passed in as arrays - refer the docs again, if issue persist please recreate it somewhere i can review and post it back.

@multimeric
Copy link

It's not a bug, it's a feature request. It should be possible to pass in sets to each of these functions, and if you do it should not attempt to convert them into a set.

@fatso83
Copy link

fatso83 commented Jan 26, 2023 •
edited
Loading

Having a package called set operations that does not work on sets is a bit misleading, so a definitive 👍 to this 🙂

fatso83 added a commit to fatso83/set-operations that referenced this issue Jan 26, 2023
@fatso83
Add support for passing in Set
f745ae0 
closes indrajaala#10
@fatso83 fatso83 linked a pull request Jan 26, 2023 that will close this issue
Open
@fatso83
Copy link

fatso83 commented Jan 26, 2023 •
edited
Loading

Support in place in PR #14 🙂

While waiting for Godot, you can use my fork in the meantime: npm i @fatso83/set-operations

@fatso83
Copy link

fatso83 commented Mar 29, 2023

@indrajaala any chance of seeing this merged soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for passing in Set fatso83/set-operations
5 participants
@fatso83 @esromneb @multimeric @ydinari @indrajaala