Skip to content

fix: async write prec where DEFAULT_PRECISION should not be used #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2024
Merged

fix: async write prec where DEFAULT_PRECISION should not be used #675

merged 5 commits into from
Oct 9, 2024
+159 −23

Conversation

karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Oct 7, 2024 •
edited
Loading

Closes #669

Proposed Changes

  • set argument precision_from_point in internal _serialize method to True.
  • detect WritePrecision key in resulting payload
  • use the key to set precision argument in call to internal _write_service.post_write_async
  • update test_write_points_different_precision to cover more current possible values

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@karel-rehor karel-rehor requested review from bednar and alespour October 7, 2024 09:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49%. Comparing base (28a4a04) to head (e679858).
Report is 7 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage   90.47%   90.49%   +0.01%     
==========================================
  Files          40       40              
  Lines        3528     3534       +6     
==========================================
+ Hits         3192     3198       +6     
  Misses        336      336

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alespour alespour self-requested a review October 8, 2024 14:06
alespour
alespour approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bednar
bednar approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@karel-rehor karel-rehor merged commit 7e01edb into master Oct 9, 2024
15 checks passed
@karel-rehor karel-rehor deleted the fix/AsyncWritePrec branch October 9, 2024 07:57
@bednar bednar added this to the 1.47.0 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

@alespour alespour alespour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

Asynchronous client ignoring write precision when set on Point
4 participants
@karel-rehor @codecov-commenter @bednar @alespour