Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Add wheel/twine support #139

Merged
merged 1 commit into from
Mar 30, 2015
Merged

Add wheel/twine support #139

merged 1 commit into from
Mar 30, 2015

Conversation

mattrobenolt
Copy link
Contributor

  • installing from a wheel is much faster than from source.
  • twice is for securely uploading the package to pypi

@gst
Copy link
Contributor

gst commented Mar 30, 2015

Once #142 will have been merged, can you rebase your branch on master ? then it should pass the tests.
Thx.

@mattrobenolt
Copy link
Contributor Author

👍

@aviau
Copy link
Collaborator

aviau commented Mar 30, 2015

Don't bother rebasing. I can merge anyways.

aviau added a commit that referenced this pull request Mar 30, 2015
@aviau aviau merged commit 36c1154 into influxdata:master Mar 30, 2015
@aviau
Copy link
Collaborator

aviau commented Mar 30, 2015

Thank you for contributing!

@aviau
Copy link
Collaborator

aviau commented Mar 30, 2015

Twine kind of broke a release. I tried uploading 1.0.1 and and it didn't let me enter my gpg passphrase. It ended up uploading a bad signature and I had to bump the version to 1.0.2. I'm on twine v1.3.1, I'll try again with the latest version next time.

@mattrobenolt
Copy link
Contributor Author

Really? :( /cc @dstufft

@dstufft
Copy link

dstufft commented Mar 30, 2015

That's odd... All twine is doing is subprocess to gpg. and failing to sign should get a non zero exit code and stop the upload.

You can test things on testpypi.python.org before sending to pypi.python.org for what it's worth. Also twine lets you pre-sign files too. Just specify the .asc files on the CLI invocation too like:

$ twine upload foo-1.0.tar.gz foo-1.0.tar.gz.asc

@aviau
Copy link
Collaborator

aviau commented Mar 30, 2015

This is my log

reazem@cranberry:~/git/influxdb-python$ twine upload --sign dist/*
Uploading distributions to https://pypi.python.org/pypi
Signing influxdb-1.0.0-py2.7.egg

You need a passphrase to unlock the secret key for
user: "Alexandre Viau alexandre@alexandreviau.net"
4096-bit RSA key, ID 3CCC3A3A, created 2014-04-01

Uploading influxdb-1.0.0-py2.7.egg
Signing influxdb-1.0.1-py2.py3-none-any.whl

You need a passphrase to unlock the secret key for
user: "Alexandre Viau alexandre@alexandreviau.net"
4096-bit RSA key, ID 3CCC3A3A, created 2014-04-01

Uploading influxdb-1.0.1-py2.py3-none-any.whl

@dstufft
Copy link

dstufft commented Mar 30, 2015

It didn't prompt you for the passphrase at all, or when it did it didn't let you type it in?

@aviau
Copy link
Collaborator

aviau commented Mar 30, 2015

It didn't prompt me for the password. When I saw that the 3 files still got uploaded I canceled with CTRL-C. Maybe I should have waited for the command to complete?

Then I tried to upload again and pypi told me the files were already there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants