Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Add a "simple" test case to verify the mean() good behavior #141

Closed
wants to merge 1 commit into from

Conversation

gst
Copy link
Contributor

@gst gst commented Mar 30, 2015

Quite simple test verifying the good behavior of the mean() function.

@aviau
Copy link
Collaborator

aviau commented Mar 30, 2015

The point of this library is not to test InfluxDB. What are you trying to do here?

@gst
Copy link
Contributor Author

gst commented Mar 30, 2015

yeaaah sure ;)

that's for the same reason than the others tests with a server instance running: it ease to detect change of format response from the server..

and as far as it's possible to use a real server instance then I find it far better than using mock of requests package..

no more, no less ;)

@gst
Copy link
Contributor Author

gst commented Mar 30, 2015

The point of this library is not to test InfluxDB

the point is of the library is to offer a python client library to query an influxdb server.

So I find that actually testing the good behavior of this client library when used against a real server is the best thing to actually test the client itself. don't you think ?

@gst
Copy link
Contributor Author

gst commented Mar 30, 2015

I will rebase it once #142 has been merged. this one also needs it because of last server update..

@aviau
Copy link
Collaborator

aviau commented Mar 30, 2015

Using a function does not affect the response format, so you are not testing anything meaningful here. The library does not do anything different because you have used mean in your query.

This test would make sense in the InfluxDB repository if you wanted to test that 30 +60+30 / 3 = 40

@gst
Copy link
Contributor Author

gst commented Mar 30, 2015

Using a function does not affect the response format

hmm, it might be, but that's not necessarily (always) the case.. The server could use different formatting function(s) (for building its response) depending on the query and what it contains..

but you're right that this kind of tests could (or should) also be part of the server test itself..

@aviau
Copy link
Collaborator

aviau commented Mar 30, 2015

this kind of tests could (or should) also be part of the server test itself..

For the reasons stated above, I think that it should only be part of the server so I will not merge this.

@aviau aviau closed this Mar 30, 2015
@gst gst deleted the test_mean_simple branch April 13, 2015 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants