Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Correctly check that the given serie name has the correct type #157

Merged

Conversation

gst
Copy link
Contributor

@gst gst commented Apr 9, 2015

type(b''.decode()) should give unicode or str depending if on python<3 or python>=3.

@gst gst force-pushed the fix_check_for_correct_types branch from bd38f28 to 9956724 Compare April 9, 2015 19:18
@gst
Copy link
Contributor Author

gst commented Apr 9, 2015

grrr

@aviau
Copy link
Collaborator

aviau commented Apr 9, 2015

hehe!

type(b''.decode()) should give unicode or str depending if on python<3 or python>=3.
@gst gst force-pushed the fix_check_for_correct_types branch from 9956724 to 05104ff Compare April 9, 2015 20:13
@gst
Copy link
Contributor Author

gst commented Apr 9, 2015

rhaaa

@aviau
Copy link
Collaborator

aviau commented Apr 9, 2015

Wohoo!

aviau added a commit that referenced this pull request Apr 9, 2015
…ypes

Correctly check that the given serie name has the correct type (Thanks @gst!)
@aviau aviau merged commit 5ea7282 into influxdata:master Apr 9, 2015
@aviau aviau deleted the fix_check_for_correct_types branch April 9, 2015 20:57
@aviau
Copy link
Collaborator

aviau commented Apr 9, 2015

@gst thank you <3

@gst
Copy link
Contributor Author

gst commented Apr 9, 2015

welcome ;)

@ChristopherRabotin
Copy link
Contributor

Haha, reading this comment thread by email makes so little sense. 😀

On Thu, Apr 9, 2015, 22:03 Grégory Starck notifications@github.com wrote:

welcome ;)


Reply to this email directly or view it on GitHub
#157 (comment)
.

@aviau
Copy link
Collaborator

aviau commented Apr 9, 2015

Haha, Indeed that must have been complicated to understand. He had to amend the commit several times to make it work.

@gst
Copy link
Contributor Author

gst commented Apr 9, 2015

This wasn't funny on my side but i understand it was from an external view ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants