-
Notifications
You must be signed in to change notification settings - Fork 524
Conversation
Hi, Thank you for taking on this issue :) Have you looked at You are using the Other than that, this looks great! //cc @timtroendle |
@ReAzem In case you haven't reviewed it, a few basic tests were added in |
# Conflicts: # tests/influxdb/client_test_with_server.py
@tzonghao Hello, Thank you for the great work. Why are you not using the ResultSet Object? You should not have to use the raw property. |
@ReAzem You're right. Using ResultSet is cleaner. It's converted in the last commit. |
@tzonghao Can you change the write_points function to accept three arguments instead?
I think it would be more intuitive than a tuple of key-value tuples. That would be my last request before we merge :) |
@ReAzem Sure, I can make that change. It also implicates that |
@tzonghao I think it would be worth it, do you agree? |
I agree. It's a good decision. |
@ReAzem It looks like an InfluxDB error in the last Travis run that failed the py34 test. Can you trigger a rerun? |
@@ -22,6 +22,9 @@ def main(host='localhost', port=8086): | |||
print("Write DataFrame") | |||
client.write_points({'demo': df}) | |||
|
|||
print("Write DataFrame with Tags") | |||
client.write_points({('demo', (('k1', 'v1'), ('k2', 'v2'))): df}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
Great work! I will be merging this for now. I'm sure we can keep on improving it after feedback from other users. |
DataFrameClient for InfluxDB 0.9 (Thanks @tzonghao !)
#108
get_list_series
returns a mapping from measurement names to DataFrame representing tags for the named measurement.query
returns a mapping from (measurement, (tag (k, v) pairs), to DataFrame representing time series for the measurement (qualified by tags) in question. Query without tags should simply use measurement as keys.write_points
converts a mapping of DataFrame objects aspoints
, then hand them over to super'swrite_points
.