Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Allow mixed case in DSN (closes #176) #178

Merged
merged 2 commits into from
May 5, 2015
Merged

Allow mixed case in DSN (closes #176) #178

merged 2 commits into from
May 5, 2015

Conversation

aviau
Copy link
Collaborator

@aviau aviau commented May 3, 2015

@cannium What do you think?

That would close #176

@ChristopherRabotin
Copy link
Contributor

I think the reason why I converted this to lower case is to make sure that the protocol is correctly identified even if it's given in uppercase. Maybe would it be worth doing the protocol check with the lowercase version of the DSN.

@aviau
Copy link
Collaborator Author

aviau commented May 4, 2015

Oh. I pinged the wrong guy. My bad :)

You are right, it would be a good idea convert the case to check for the protocol.

I'll give a try tomorrow.

@cannium
Copy link
Contributor

cannium commented May 4, 2015

@ReAzem No problem.
The scheme part(https+influxdb) should be converted to lower case to check, and other parts(like username, password) are case sensitive, in my opinion.

@aviau
Copy link
Collaborator Author

aviau commented May 4, 2015

Looks like it already worked. urlparse does the work for us.

@aviau
Copy link
Collaborator Author

aviau commented May 5, 2015

@ChristopherRabotin Any feedback? Good to merge?

@ChristopherRabotin
Copy link
Contributor

@ReAzem looks good, nothing to add. Thanks for asking!

aviau added a commit that referenced this pull request May 5, 2015
Allow mixed case in DSN (closes #176)
@aviau aviau merged commit b022683 into master May 5, 2015
@aviau
Copy link
Collaborator Author

aviau commented May 5, 2015

Thank you :)!

@aviau aviau deleted the issue_176 branch May 5, 2015 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_DSN won't work with upper case passwords
3 participants