This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Create db only if doesn't exist yet #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slomek Have you taken a look at the tests failures? |
|
Yep, I've had some issues with running them locally. I've changed the default behaviour to create dbs if they do not exist, but also added a flag if you want to fail anyway (and not to delete one of your tests). This breaks backward compatibility a little, but in my opinion it would be better this way. |
|
@aviau Can you merge this or is there anything else I should fix first? |
|
@slomek I am sorry for the long response time. Can you please switch the default around? Some people may rely on this throwing exceptions and I think its a saner default. I will merge right after! |
|
No problem, @aviau. Take a look on it now. |
|
Thanks!! |
aviau
added a commit
that referenced
this pull request
Jan 3, 2016
Create db only if doesn't exist yet (Thanks @slomek !)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #274