This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Some exceptions could be raised before sending data to server #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this piece of code is executed:
This exception is raised:
The lib is telling us that there is some problem with the servers, but it is not actually the real problem.
The problem is using a string timestamp instead of integer.
The flow is:
https://github.com/influxdata/influxdb-python/blob/master/influxdb/client.py#L276 ->
https://github.com/influxdata/influxdb-python/blob/master/influxdb/line_protocol.py#L131 -> https://github.com/influxdata/influxdb-python/blob/master/influxdb/line_protocol.py#L17 ->
finally calling dateutil.parser.parse("1453120639") that raises:
With this PR, that exception is catched and displayed to the user.
I think the error is assuming that all exceptions excluding InfluxDBClientError are server errors: https://github.com/influxdata/influxdb-python/blob/master/influxdb/client.py#L884