This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Add get_list_privileges() to InfluxDBClient #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed that this PR is pretty similar to #322, but I prefer to use |
This allows library users to get a list of all privileges an InfluxDB user has been granted.
These test check for correct return value and exception handling in case of incorrect usage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows library users to get a list of all privileges an InfluxDB
user has been granted.
One problematic aspect of this method is that, due to influxdata/influxdb#4511 the interface of privilege related methods is inconsistent.
We could perform the normalisation (removal of elements with
NO PRIVILEGESandALL PRIVILEGES→ALL) in the Python library, but I would prefer to keep the library simple and to see this fixed this in InfluxDB itself.On the other hand including it would probably lead to client code that performs the normalisation itself and that would have to be adapted once these inconsistencies have been resolved.