This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Add grant_admin_privileges() to InfluxDBClient #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BABILEN I'd love to see the tests passing before merging this. I tank you for your contribution, would you like to open a PR to fix the tests? |
|
You are right, but the fact that there are failing tests makes reviewing pull requests longer for me because I have to read the logs and see what is failing and what isn't. |
|
Sure, I totally understand. It's just that f97effe introduced significant changes and I am, as of now, not entirely sure how to fix it. I will, however, take a look. |
This allows users to easily alter the 'admin' attribute of a user account and complements the already existing 'revove_admin_privileges' method.
These tests simply check for correct query generation and exception handling if used incorrectly by passing in an empty string as username.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to easily alter the 'admin' attribute of a user
account and complements the already existing 'revove_admin_privileges'
method.