add ping method to the client #409
Conversation
influxdb/client.py
Outdated
| @@ -410,6 +410,18 @@ def write_points(self, | |||
| retention_policy=retention_policy, | |||
| tags=tags, protocol=protocol) | |||
|
|
|||
| def ping(self): | |||
| """Check connectivity to influxdb | |||
There was a problem hiding this comment.
Minor thing, but summary should end in a period and influxdb replaced with InfluxDB, so that it will be in the same style as other docstrings. Also, there should be a blank line after the summary line (PEP 257). Otherwise, having this method would be really useful in my opinion 👍
There was a problem hiding this comment.
Sure, I'll fix that
influxdb/client.py
Outdated
| """ | ||
|
|
There was a problem hiding this comment.
Blank line should be after the summary line (i.e. the first line of the docstring), before the description. In PEP 257 no blank lines allowed after the method's docstring. Also, please note that PEP 257 requires that the first line of the docstring ends with the period.
On the other side, there are currently quite many inconsistencies in the client's docstrings and tox does not check code for PEP 257. May be all these inconsistencies should be revised in a separate PR.
There was a problem hiding this comment.
Doh! I'll fix that, and create an issue for fixing pep257 in the remaining files
fixing up failing CI tests
fixing up failing CI tests
a method to invoke the
/pingendpoint so it is easy to verify connectivity