Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

move use_udp and udp_port private #477

Merged
merged 1 commit into from
Aug 15, 2017
Merged

move use_udp and udp_port private #477

merged 1 commit into from
Aug 15, 2017

Conversation

sebito91
Copy link
Contributor

@sebito91 sebito91 commented Jul 7, 2017

Fixes #241

@sebito91
Copy link
Contributor Author

sebito91 commented Jul 7, 2017

@aviau READY TO MERGE

@sebito91 sebito91 mentioned this pull request Jul 7, 2017
Closed
@aviau
Copy link
Collaborator

aviau commented Jul 7, 2017

I'd like a property for transition please <3

@sebito91
Copy link
Contributor Author

@aviau added fixup for this, will squash when you approve.

@aviau
Copy link
Collaborator

aviau commented Aug 15, 2017

Would you like to merge yourself? ;)

@sebito91
Copy link
Contributor Author

Yes, yes I would :D

@sebito91 sebito91 self-assigned this Aug 15, 2017
@sebito91 sebito91 requested a review from aviau August 15, 2017 12:40
@sebito91
Copy link
Contributor Author

Can't review my own PR, if you would be so kind please @aviau?

@sebito91 sebito91 merged commit d8907d3 into influxdata:master Aug 15, 2017
@sebito91 sebito91 deleted the udp_priv branch August 15, 2017 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aviau aviau aviau approved these changes

Assignees

@sebito91 sebito91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebito91 @aviau