Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Fix for DataFrameClient issue - seems does not process correctly DateTimeIndex dates (issue #479) #495

Merged
merged 11 commits into from
Nov 25, 2017

Conversation

patrickhoebeke
Copy link
Contributor

@patrickhoebeke patrickhoebeke commented Aug 24, 2017

Fix for #479
Force conversion to 64bits integer (as astype(int) converts to 32bits on some machines and to 64bits on others). 64bits conversion is required.

patrickhoebeke and others added 5 commits May 18, 2017 18:10
pd.tseries.period.PeriodIndex has been moved to pd.PeriodIndex since at least pandas 0.18.1
pd.tseries.period.DatetimeIndex has been moved to pd.DatetimeIndex since at least pandas 0.18.1
…to Unix Epoch (e.g .on (some?) Windows machines)
…erted to Unix Epoch (e.g .on (some?) Windows machines)
@patrickhoebeke
Copy link
Contributor Author

patrickhoebeke commented Aug 24, 2017

Two remaining questions:

  1. Is this fix compliant with 32bits machine? If fear that if we want to provide nanoseconds timestamps inputs to Influx, 64bits is a requirement. Then, so should it be part of some check when running the code? => just checked, the trick "np.int64" works perfectly on Windows 32bit machine => cool
  2. I am not sure whether a specific unittest is required

@patrickhoebeke patrickhoebeke changed the title Fix for DataFrameClient issue - seems does not process correctly DateTimeIndex dates (#494) Fix for DataFrameClient issue - seems does not process correctly DateTimeIndex dates (#479) Aug 24, 2017
@patrickhoebeke patrickhoebeke changed the title Fix for DataFrameClient issue - seems does not process correctly DateTimeIndex dates (#479) Fix for DataFrameClient issue - seems does not process correctly DateTimeIndex dates (influxdata/influxdb-python#479) Aug 24, 2017
@patrickhoebeke patrickhoebeke changed the title Fix for DataFrameClient issue - seems does not process correctly DateTimeIndex dates (influxdata/influxdb-python#479) Fix for DataFrameClient issue - seems does not process correctly DateTimeIndex dates (close #479) Aug 24, 2017
@patrickhoebeke patrickhoebeke changed the title Fix for DataFrameClient issue - seems does not process correctly DateTimeIndex dates (close #479) Fix for DataFrameClient issue - seems does not process correctly DateTimeIndex dates (issue #479) Aug 24, 2017
@xginn8 xginn8 merged commit bf232a7 into influxdata:master Nov 25, 2017
@xginn8
Copy link
Collaborator

xginn8 commented Nov 25, 2017

thanks for contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants