Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Fix issues #422 and #479 #507

Closed

Conversation

patrickhoebeke
Copy link
Contributor

[FIX] : Fix issue #422
with this implementation, now DataFrameClient allow to push DataFrame with null values (NaNs or None)

  • Issue: DataframeClient fails to push DataFrame with NaNs
  • Root cause : null are not allowed on Influx (null is not a valid type)
  • Possible work around: push column per column (with dropnan() before each push)
  • Solution : corresponding points are dropped from the list of points pushed to influx. Also takes into account full lines with nulls and DataFrame full of nulls)

[FIX] : Fix issue #479
conversion of DatetimeIndex to epoch was not correct on some machines.

  • Issue : on some Windows machines, DatetimeIndex not correctly converted to epoch
  • Root cause: to convert to Epoch, timestamp is first converted to int. On some machines, default conversion to int leads to a conversion to int32 (which lead to incorrect conversion to epoch). Conversion to int should be to int64.
  • Solution: conversion forced to int64 in the code

[FIX] :  Timestamps not correctly converted to epoch on some systems
@@ -18,4 +18,4 @@
]


__version__ = '4.1.1'
__version__ = '4.1.1b'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't bump the version in pull requests.

@tux-00
Copy link

tux-00 commented May 17, 2018

In commit f40f770 you use dropna() but this method seems to delete all the row (https://pandas.pydata.org/pandas-docs/stable/generated/pandas.DataFrame.dropna.html).

Maybe I'm wrong but I use this code to drop NaN values : df.fillna('') instead of dropna().

Warning : df.fillna('') changes dtype to object.

@sebito91 sebito91 self-assigned this Apr 8, 2020
@sebito91
Copy link
Contributor

sebito91 commented Apr 8, 2020

Closing stale request, addressed in later release.

@sebito91 sebito91 closed this Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants