This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Add some small improvements #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- six is already listed as a requirement, so use six.moves instead of defining builtins based on checking sys.version_info - Fix formatting of several exceptions.
swails
commented
Nov 9, 2017
| raise TypeError('Must be DataFrame with DatetimeIndex or \ | ||
| PeriodIndex.') | ||
| raise TypeError('Must be DataFrame with DatetimeIndex or ' | ||
| 'PeriodIndex.') |
There was a problem hiding this comment.
If this was ever raised, the formatting would end up looking weird:
>>> raise TypeError('this is a long error message \
... that gets split over lines, but look \
... at all those spaces!')
Traceback (most recent call last):
File "<stdin>", line 3, in <module>
TypeError: this is a long error message that gets split over lines, but look at all those spaces!| if _error: | ||
| raise(_error) | ||
| if not retry: | ||
| raise |
There was a problem hiding this comment.
linters like this approach a little better, and it also gives more digestible tracebacks IMO:
>>> e = None
>>> try:
... raise ValueError('this is a raised value error')
... except ValueError as _e:
... e = _e
...
>>> raise(e)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "<stdin>", line 2, in <module>
ValueError: this is a raised value error>>> try:
... raise ValueError('this is a raised value error')
... except ValueError:
... raise
...
Traceback (most recent call last):
File "<stdin>", line 2, in <module>
ValueError: this is a raised value errorThis seems to be the original intent.
xginn8
approved these changes
Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defining builtins based on checking sys.version_info